Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confirmation toggle and course info heading default #2854

Merged

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Jan 17, 2025

Description

Can now disable the "confirmation" toggle for blocks like Email address and User Password.

Also changes Course Information block header from h3 to h2 by default, to have the correct heading over.

Fixes #2646 and gocodebox/lifterlms-blocks#243

How has this been tested?

Manually

Screenshots

image

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg requested a review from ideadude as a code owner January 17, 2025 15:35
@brianhogg brianhogg merged commit 3d43315 into dev Jan 17, 2025
30 checks passed
@brianhogg brianhogg deleted the fix-confirmation-toggle-and-course-info-heading-default branch January 17, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant