Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go (build/test) version to 1.23 #338

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Update Go (build/test) version to 1.23 #338

merged 5 commits into from
Nov 26, 2024

Conversation

0x0013
Copy link
Contributor

@0x0013 0x0013 commented Nov 26, 2024

We are seeing errors in GH action tests, such as:

go.mod:3: invalid go version '1.23.0': must match format 1.23

This is due to older versions of Go not supporting X.Y.Z versioning, and prevents any changes due to failing CI.

To resolve this, update the Go version used by GH actions to the latest stable 1.23.3. For consistency, also update the version used for build in Dockerfile and asdf .tool-versions.

Some downstream changes were also done because of this:

New release should not be needed since this is a non-functional change.

@0x0013 0x0013 changed the title Pin envtest version Update Go (build/test) version to 1.23 Nov 26, 2024
@0x0013 0x0013 marked this pull request as ready for review November 26, 2024 14:42
@0x0013 0x0013 merged commit aec5d53 into master Nov 26, 2024
9 checks passed
@0x0013 0x0013 deleted the update-go branch November 26, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants