Revert "Change how rules are referenced" #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 22e7943.
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| Gem::Specification.new do |spec| | |||
| spec.name = 'gc_ruboconfig' | |||
| spec.version = '5.0.1' | |||
| spec.version = '5.0.0' | |||
There was a problem hiding this comment.
can we update these then
spec.add_dependency 'rubocop', '>= 1.63'
spec.add_dependency 'rubocop-factory_bot', '>= 2.26.1'
spec.add_dependency 'rubocop-performance', '>= 1.21'
spec.add_dependency 'rubocop-rails', '>= 2.25.0'
spec.add_dependency 'rubocop-rspec', '>= 3.0.1'
spec.add_dependency 'rubocop-rspec_rails', '>= 2.30.0'
There was a problem hiding this comment.
Sure, go for it :)
Just do it in this PR, or a separate one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #124
This change fixes an issue caused by a downstream service not having the new
rubocop-factory_botgem in its dependencies, but does it in the wrong way. These old namespaces were deprecated long ago and the correct fix is to add a dependency on the new gem, either here or in services that depend on this gemSee https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html