Skip to content

Commit

Permalink
Disable Rails/WhereRange
Browse files Browse the repository at this point in the history
There may be some confusion over `..` vs `...` for some new to Ruby
  • Loading branch information
JoeSouthan committed May 17, 2024
1 parent 8e69425 commit ea7681a
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
release:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
- name: Publish Gem
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ jobs:
validate:
strategy:
matrix:
ruby-version: [2.7, 3.0, 3.1, 3.2]
ruby-version: [2.7, 3.0, 3.1, 3.2, 3.3]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.2
3.3.1
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
Changelog
=========

4.5.0
-----
* Disable `Rails/WhereRange`

4.4.2
-----
* Adjust renamed cops
* Disable RSpec/ExampleWording

4.4.1
-----
* Disable `HashEachMethods` style for [Style/HashEachMethods](https://docs.rubocop.org/rubocop/cops_style.html#stylehasheachmethods)
Expand Down
10 changes: 5 additions & 5 deletions gc_ruboconfig.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@

Gem::Specification.new do |spec|
spec.name = 'gc_ruboconfig'
spec.version = '4.4.2'
spec.version = '4.5.0'
spec.summary = "GoCardless's shared Rubocop configuration, conforming to our house style"
spec.authors = %w[GoCardless]
spec.homepage = 'https://github.com/gocardless/ruboconfig'
spec.email = %w[[email protected]]
spec.license = 'MIT'

spec.files = ['rubocop.yml', 'rails.yml']
spec.add_dependency 'rubocop', '>= 1.50.0'
spec.add_dependency 'rubocop-performance', '>= 1.15'
spec.add_dependency 'rubocop-rails', '>= 2.17.2'
spec.add_dependency 'rubocop-rspec', '>= 2.22.0'
spec.add_dependency 'rubocop', '>= 1.63'
spec.add_dependency 'rubocop-performance', '>= 1.21'
spec.add_dependency 'rubocop-rails', '>= 2.25.0'
spec.add_dependency 'rubocop-rspec', '>= 2.29.2'
end
3 changes: 3 additions & 0 deletions rails.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,6 @@ Rails/IgnoredColumnsAssignment: # new in 2.17
# Only relevant for Rails < 6.1
Rails/WhereNotWithMultipleConditions: # new in 2.17
Enabled: false

Rails/WhereRange: # New in 2.25
Enabled: false

0 comments on commit ea7681a

Please sign in to comment.