Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies of the pubsub gem #37

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

VSpike
Copy link

@VSpike VSpike commented Oct 11, 2024

The upstream fork has had some updates but our fork has diverged quite a lot. Update the Google Client gem.

We are seeing messages in the build of our FluentD setup like this:

Post-install message from google-gax:
*******************************************************************************
The google-gax gem is officially end-of-life and will not be updated further.

If your app uses the google-gax gem, it likely is using obsolete versions of
some Google Cloud client library (google-cloud-*) gem that depends on it. We
recommend updating any such libraries that depend on google-gax. Modern Google
Cloud client libraries will depend on the gapic-common gem instead.
*******************************************************************************

@VSpike VSpike requested a review from a team October 11, 2024 14:00
The upstream fork has had some updates but our fork has diverged quite a
lot. Update the Google Client gem and Prometheus gem.

We are seeing messages in the build of our FluentD setup like this:

```
Post-install message from google-gax:
*******************************************************************************
The google-gax gem is officially end-of-life and will not be updated further.

If your app uses the google-gax gem, it likely is using obsolete versions of
some Google Cloud client library (google-cloud-*) gem that depends on it. We
recommend updating any such libraries that depend on google-gax. Modern Google
Cloud client libraries will depend on the gapic-common gem instead.
*******************************************************************************
```
@VSpike VSpike force-pushed the INC-3816_update_pubsub_gem branch from a56685d to e8bb732 Compare October 11, 2024 14:01
@VSpike VSpike self-assigned this Oct 11, 2024
Copy link

@asanord asanord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a big bump. I am assuming this will be rolled out responsibly.

@bencord0
Copy link

I think you also need to update .github/workflows/test.yaml with the ruby version bump.

Bump Ruby version in the Github Actions config.
Remove the Travis config as we are not using it.
Update the target version in Rubocop.
@VSpike
Copy link
Author

VSpike commented Oct 14, 2024

I think you also need to update .github/workflows/test.yaml with the ruby version bump.

Thanks! Done.

@VSpike VSpike merged commit b761c72 into gocardless Oct 14, 2024
1 check passed
@VSpike VSpike deleted the INC-3816_update_pubsub_gem branch October 14, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants