[HACK] ReSpecd - Lazy-load client libraries. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when loading the gem we also implicitly load the client libraries for the bucket providers. These are quite large, and increase the time to load the gem (and the number of files included) by orders of magnitude. To avoid unnecessary slowing down the bootstrap, we can instead load these gems only if the provider is used, and memoise this on the class to avoid repeated calls to `require` (as this returns `true` when the library is first required). In testing with Rails, lazy-loading these libraries reduces the time taken for Bundler to require the gem during bootstrap from 0.25 to 0.005 seconds (yes, that's two orders of magnitude faster).
benk-gc
force-pushed
the
benk--lazy-load-client-libraries
branch
from
1e7f761 to
456302c
Compare
benk-gc
changed the title
ivgiuliani
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when loading the gem we also implicitly load the client libraries for the bucket providers. These are quite large, and increase the time to load the gem (and the number of files included) by orders of magnitude.
To avoid unnecessary slowing down the bootstrap, we can instead load these gems only if the provider is used, and memoise this on the class to avoid repeated calls to
require(as this returnstruewhen the library is first required).In testing with Rails, lazy-loading these libraries reduces the time taken for Bundler to require the gem during bootstrap from 0.25 to 0.005 seconds (yes, that's two orders of magnitude faster).