-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide mutex structure contents and standard globals in base analysis #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This avoids unknown value escape warnings.
sim642
changed the title
Hide mutex structure contents in base analysis
Hide mutex structure contents and standard globals in base analysis
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We might want to enhance this mutex data type with information such as whether it is initialized or whether it is recursive at some later point, but this already is a step in the right direction!
michael-schwarz
approved these changes
Jul 28, 2022
jerhard
requested changes
Jul 28, 2022
jerhard
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #745 (comment).
@michael-schwarz:
@sim642:
This is to avoid large amounts of invariants about
pthread_mutex_t
contents, which are actually all incorrect, since base analysis never updates them from their initialized values. Hiding them from elsewhere (e.g. g2html) would improve readability as well, but so far such mutex type ignoring was only done for accesses, not base.Additionally, it (optionally) hides unknown globals from standard headers, e.g.
__tzname
, etc, such that they wouldn't always clutter local states.