Bitfield Domain #1623
Draft
Bitfield Domain #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d some revision. Possible side-effects and runtime in O(n^2) while O(n) should be possible.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Semgrep OSS found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…act bitfield by eliminating constants that would result in a shift to zero beforehand
* implemented modulo * current changes * implementation of add, sub, mul based on paper * implemented neg * bug fixes for arith operators --------- Co-authored-by: Adrian Krauß <[email protected]>
Overflow and wrapping
…unknown bits and introduced module for infix ops on bitfields
Bugfixes for problems found by quickcheck
| norm ik (z3, o3) | ||
|
|
||
| let neg ?no_ov ik x = | ||
| M.trace "bitfield" "neg"; |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: semgrep.trace-not-in-tracing Warning
| let lognot ik i1 = BArith.lognot i1 |> norm ik |> fst | ||
|
|
||
| let shift_right ik a b = | ||
| M.trace "bitfield" "shift_right"; |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: semgrep.trace-not-in-tracing Warning
| else norm ik (BArith.shift_right ik a b) | ||
|
|
||
| let shift_left ik a b = | ||
| M.trace "bitfield" "shift_left"; |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: semgrep.trace-not-in-tracing Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new bitfield domain, into the IntDomain.
Currently being worked on...