Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid emitting reflexive pointer refines for locking #1407

Merged
merged 3 commits into from
May 7, 2024
Merged

Avoid emitting reflexive pointer refines for locking #1407

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96e7b37
mutexEvents: Do not emit refines of form `&a=&a`
michael-schwarz Mar 28, 2024
66107c8
Merge branch 'issue_1140' into issue-1374-3
sim642 May 6, 2024
f8f39eb
Deduplicate Mval.to_cil conversion in mutexEvents analysis
sim642 May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/analyses/mutexEventsAnalysis.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,12 @@ struct
let lock ctx rw may_fail nonzero_return_when_aquired a lv_opt arg =
let compute_refine_split (e:Mutexes.elt) = match e with
| Addr a ->
let e' = BinOp(Eq, arg, AddrOf ((PreValueDomain.Mval.to_cil a)), intType) in
[Events.SplitBranch (e',true)]
let arg_e = AddrOf (PreValueDomain.Mval.to_cil a) in
if not (CilType.Exp.equal arg arg_e) then
let e' = BinOp (Eq, arg, arg_e, intType) in
[Events.SplitBranch (e', true)]
else
[]
| _ -> []
in
match lv_opt with
Expand Down
Loading