Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle LNot for float in forward evaluation and refinement on guards #1344

Merged
merged 4 commits into from
Feb 4, 2024
Merged

Handle LNot for float in forward evaluation and refinement on guards #1344

merged 4 commits into from
Feb 4, 2024

Conversation

michael-schwarz
Copy link
Member

Fixes the issues identified by @sim642 where

  • the type of the abstract values for expressions involving LNot was wrong
  • having !x for float variables x in a guard lead to crashes

Closes #1211.

@michael-schwarz michael-schwarz added this to the v2.4.0 milestone Jan 28, 2024
@sim642 sim642 self-requested a review January 29, 2024 13:24
sim642
sim642 reviewed Jan 29, 2024
View reviewed changes
src/analyses/base.ml Show resolved Hide resolved
src/analyses/base.ml Outdated Show resolved Hide resolved
@michael-schwarz michael-schwarz merged commit 71498c5 into master Feb 4, 2024
17 checks passed
@michael-schwarz michael-schwarz deleted the issue_1211 branch February 4, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sim642 sim642 sim642 approved these changes

Assignees
No one assigned
Labels
bug precision
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

LNot on floating-point values
2 participants
@michael-schwarz @sim642