Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate ctx-derived arguments in base analysis #1308

Merged
merged 50 commits into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from 45 commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
a568620
Remove gs from set signature in base
karoliineh Dec 27, 2023
fcb52df
Remove gs from set_many signature in base
karoliineh Dec 27, 2023
ae56428
Remove gs from invalidate signature in base
karoliineh Dec 27, 2023
9d13dd1
Remove gs from special_unknown_invalidate signature in base
karoliineh Dec 27, 2023
55bc2d6
Remove ask from set signature in base
karoliineh Dec 27, 2023
c740996
Remove ask from set_many signature in base
karoliineh Dec 27, 2023
05abd0d
Remove ask from invalidate signature
karoliineh Dec 27, 2023
5c27f2b
Remove ask from special_unknown_invalidate signature
karoliineh Dec 27, 2023
1575f7e
Remove unneccessary parentheses and rename a -> ask
karoliineh Dec 27, 2023
16c9a8b
Remove st from special_unknown_invalidate signature
karoliineh Dec 27, 2023
8187ac9
Add ctx to almost everywhere in base
karoliineh Dec 27, 2023
d4ef5c0
Remove ask and gs from eval_rv signature
karoliineh Dec 27, 2023
77c6f20
Remove st from eval_rv signature
karoliineh Dec 27, 2023
c0c8de3
Remove ask, gs and st from eval_rv_address signature
karoliineh Dec 27, 2023
7ae6bdd
Remove ask, gs and st from eval_rv_back_up signature
karoliineh Dec 27, 2023
7b6005e
Remove ask, gs and st from eval_lv signature
karoliineh Dec 27, 2023
b11d327
Remove ask, gs and st from convert_offset signature
karoliineh Dec 27, 2023
5f18ee7
Remove unused parameter st from evalbinop_base signature
karoliineh Dec 27, 2023
292bd8d
Remove ask, gs and st from evalbinop signature
karoliineh Dec 27, 2023
4bd1493
Remove ask, gs and st from eval_fv, eval_tv and eval_int signatures
karoliineh Dec 27, 2023
ac2839a
Remove unused parameters ask and gs from set_savetop signature
karoliineh Dec 27, 2023
f68cfa7
Repetitive usages of (Analyses.ask_of_ctx ctx) to one variable
karoliineh Dec 27, 2023
dd1b753
Remove ask, gs and st from collect_funargs and collect_invalidate sig…
karoliineh Dec 27, 2023
c065fa4
Fix some commented out code
karoliineh Dec 27, 2023
50afde7
Add ctx as parameter to reachable_vars
karoliineh Dec 27, 2023
1b617af
Remove ask, gs and st from reachable_vars signatures
karoliineh Dec 27, 2023
dc6527c
Remove the unused parameters ask, gs and st from query_evalint
karoliineh Dec 27, 2023
6d2e52d
Add ctx as parameter to get
karoliineh Dec 28, 2023
985e746
Add ctx as parameter to get_var
karoliineh Dec 28, 2023
8f8273c
Remove gs from get and get_var signatures
karoliineh Dec 28, 2023
b9be6a5
Remove ask from get and get_var signatures
karoliineh Dec 28, 2023
33875aa
Simplify `ask.f` -> `ctx.ask`
karoliineh Dec 28, 2023
6c16cdc
Remove gs from eval_rv_base_lval signature
karoliineh Dec 28, 2023
05feadd
Remove ask from eval_rv_base_lval signature
karoliineh Dec 28, 2023
8dd3332
Inline ask variables with only one usage
karoliineh Dec 28, 2023
b073b71
Remove gs from invariant, invariant_fallback and refine_lv signatures
karoliineh Dec 28, 2023
cc0285b
Remove ask from invariant, invariant_fallback, refine_lv and refine_l…
karoliineh Dec 28, 2023
3d2dc96
Remove gs from refine_lv_fallback signature
karoliineh Dec 28, 2023
f4da507
Fix get in comment
karoliineh Dec 28, 2023
8ce2825
Remove ask and gs from set signature
karoliineh Dec 28, 2023
e6752d5
Replace redundant eval_lv call with AD.singleton
karoliineh Dec 28, 2023
06a2d54
Simplify matches in combine_st
karoliineh Dec 28, 2023
b23dea3
Revert "Remove st from eval_rv signature"
karoliineh Jan 3, 2024
7c50968
Add st back everywhere (as for now)
karoliineh Jan 5, 2024
2d4f7f2
Replace ask in evalbinop_base with ctx for consistency
karoliineh Jan 5, 2024
cd871fc
Replace ctx with ask in reachable_from_value
karoliineh Jan 5, 2024
7af5e41
Add st back to reachable_vars and reachable_from_address
karoliineh Jan 5, 2024
c9ccbb6
Fix reachable_vars timing
karoliineh Jan 5, 2024
bd5d65d
Detect query cycles in eval_exp
karoliineh Jan 9, 2024
76e5d38
Avoid doing Analyses.ask_of_ctx ctx for each exp in a list
karoliineh Jan 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading