Make some exception printers lazy, do not use plain CIL printers in messages #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-schwarz
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
LGTM! Did you check that issue #1290 is fixed now? And I guess the cram tests need to be promoted now.
The evals count didn't get stuck like that, so seems like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1290.
Now all
d_plaintypeandd_plainexpshould be such that the printing only happens when part of some debug output (e.g. tracing or uncaught exception).It also changes the "Invalidating expressions" message to use normal expression printing (more meaningful for user) than the internal representation.