Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GobView build #1215

Merged
merged 18 commits into from
Feb 16, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ goblint
goblint.byte
goblint.json
goblint.domaintest
goblint-http
goblint_http.exe
src/config*.ml
tests/bench.txt
.DS_Store
Expand Down
22 changes: 19 additions & 3 deletions docs/user-guide/inspecting.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,23 @@ For the initial setup:
To build GobView (also for development):

1. Run `make view` in the analyzer directory to build the web UI
2. The executable `goblint-http.exe` takes the analyzer directory and additional Goblint configurations such as the files to be analyzed as parameters. Run it e.g. with the following command:\
`./goblint-http.exe tests/regression/00-sanity/01-assert.c`

2. The executable `goblint_http.exe` takes the analyzer directory and additional Goblint configurations such as the files to be analyzed as parameters. Run it e.g. with the following command:\
`./goblint_http.exe tests/regression/00-sanity/01-assert.c`
3. Visit <http://localhost:8080>

## Witnesses

### GraphML

#### yEd

1. Open (Ctrl+o) `witness.graphml` from Goblint root directory.
2. Click menu "Edit" → "Properties Mapper".
1. _First time:_ Click button "Imports additional configurations" and open `scripts/sv-comp/yed-sv-comp.cnfx`.
2. Select "SV-COMP (Node)" and click "Apply".
3. Select "SV-COMP (Edge)" and click "Ok".
3. Click menu "Layout" → "Hierarchial" (Alt+shift+h).
1. _First time:_ Click tab "Labeling", select "Hierarchic" in "Edge Labeling".
2. Click "Ok".

yEd manual for the Properties Mapper: <https://yed.yworks.com/support/manual/properties_mapper.html>.
2 changes: 1 addition & 1 deletion gobview
2 changes: 1 addition & 1 deletion scripts/test-gobview.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def cleanup(browser, thread):
# serve GobView in different thread so it does not block the testing
def serve():
global p
goblint_http_path = './goblint-http'
goblint_http_path = './goblint_http.exe'
p = subprocess.Popen([goblint_http_path,
'-with-goblint', '../analyzer/goblint',
'-goblint', '--set', 'files[+]', '"../analyzer/tests/regression/00-sanity/01-assert.c"'])
Expand Down
4 changes: 3 additions & 1 deletion src/maingoblint.ml
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,9 @@ let do_gobview cilfile =
(* marshal timing statistics *)
let stats = Fpath.(run_dir / "stats.marshalled") in
Serialize.marshal (Timing.Default.root, Gc.quick_stat ()) stats;
)
)
else
Logs.error "Warning: Cannot locate GobView."
sim642 marked this conversation as resolved.
Show resolved Hide resolved

let handle_extraspecials () =
let funs = get_string_list "exp.extraspecials" in
Expand Down
Loading