-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CIL's ptranal for EvalFunvar
queries
#1063
Conversation
What are our plans with this? |
Since Goblint CIL still has |
I think in this case it would be a good idea to address the open remarks and then merge this. |
I have now brought this up-to-date with master. Should we merge it as-is or address the comments above before? |
The failing indentation is already on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few small changes to make this merge-ready.
EvalFunvar
queries
This will add the option to use Cil's Ptranal module to deal with dynamic function calls. This would avoid having to run the base analysis for fast analyses. The problem is that the Ptranal module's points to queries are really literal, so
*fp
(which is how function pointer calls are normalized by CIL) does not point to anything, you have to remove the dererefence and queryfp
, and then for cases like calling through pointers within structs, the analysis is flow-insensitive and that causes some issues.