website/docs: add . in https://netbird.company* #12166
Conversation
From the documentation https://docs.netbird.io/selfhosted/identity-providers#authentik, the domain must have a . in https://netbird.company.* or you will experience a redirect error. Signed-off-by: Marcus1Pierce <[email protected]>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook canceled.
|
|
Thanks for this PR @Marcus1Pierce ! So both the period (.) and the asterisk (*) needed to be added, for the Redirect URI, right? |
oh, wait, I see... it's the second line you corrected, the asterisk was already there, you added the period. Got it. Thanks so much! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12166 +/- ##
==========================================
- Coverage 92.69% 92.61% -0.08%
==========================================
Files 761 761
Lines 38050 38050
==========================================
- Hits 35270 35241 -29
- Misses 2780 2809 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| ``` | ||
| https://netbird.company | ||
| https://netbird.company* | ||
| https://netbird.company.* | ||
| http://localhost:53000 | ||
| ``` |
There was a problem hiding this comment.
| ``` | |
| https://netbird.company | |
| https://netbird.company* | |
| https://netbird.company.* | |
| http://localhost:53000 | |
| ``` | |
| - Strict; https://netbird.company | |
| - Regex; https://netbird.company/.* | |
| - Strict; http://localhost:53000 |
I'm not sure about the 2nd entry in the list, but just having .* at the end would be an insecure configuration
There was a problem hiding this comment.
I tried with https://netbird.company/.* or https://netbird.company.* and it seems there are no issues. But if I don't add .* to the regex (ex. https://netbird.company/* or https://netbird.company*), for some reason, the Redirect URI Error always appears as shown in the image.
There was a problem hiding this comment.
OK, thanks @Marcus1Pierce for your patience. In the last release, we updated the Redirect URI fields such that you can select Strict or Regex format. So exactly as @BeryJu 's suggested change shows, we want users to indicate that it is Regex if they use the https://netbird.company/.* format.
Here's what that field looks like now:
There was a problem hiding this comment.
@tanberry I tried as suggested by @BeryJu and everything works fine.
Or as suggested on the website https://docs.netbird.io/selfhosted/identity-providers#authentik (all using regex) as below also works fine.
I don't know which is the best, but from what I tried, everything works fine.
There was a problem hiding this comment.
Using all regex is insecure without escaping (which is why we added the configuration options for the comparison mode)
There was a problem hiding this comment.
Hi again @Marcus1Pierce good to hear this works. Please make the change to the file with @BeryJu 's suggestion, run the linters again (make website), and push again, and then we can merge.
Change https://netbird.company* to https://netbird.company/.* Signed-off-by: Marcus1Pierce <[email protected]>
Details
From the documentation https://docs.netbird.io/selfhosted/identity-providers#authentik, the domain must have a . in https://netbird.company.* or you will experience a redirect error.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)