forked from samuel/go-zookeeper
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BC] CreateMode: refactor and fix FlagX Create flags. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 77.98% 78.50% +0.51%
==========================================
Files 7 8 +1
Lines 1322 1349 +27
==========================================
+ Hits 1031 1059 +28
Misses 199 199
+ Partials 92 91 -1 ☔ View full report in Codecov by Sentry. |
Based on the PR #125 that shows the issue at hand. The bug was in the CreateContainer and CreateTTL methods. |
…eate flags BREAKING Client behavior: since this proposes a new parsing of the Create flag integer this will break clients if they rely on CreateContainer as it was creating znodes that may not have been containers. Changes: - Fix FlagTTL value from 4 -> 5 - Adding all known CreateMode values to Flag constants. - Adding a createMode private struct behind the flag integer, replicate CreateMode from ZK java lib. - Create, CreateContainer, CreateTTL methods now parse the flag integer passed in based on the constants defined. - Rewrite tests to better catch CreateContainer and CreateTTL (no assertions on zk behavior since zk does not expose znode mode) - Added Change-Detector unit tests for create mode values.
note this commit shows the fact we don't need CreateContainer as a method, its an argument to Create. TTL is still needed from having a different payload, but later could be logic in Create based on the CreateMode we are given.
MKrupauskas
approved these changes
Jun 29, 2024
MKrupauskas
approved these changes
Jul 1, 2024
For others that may face new errors:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING Client behavior: since this proposes a new parsing of the Create flag integer this will break clients if they rely on CreateContainer as it was creating znodes that may not have been containers.
Changes: