Merge pull request #428 from go-vgo/bitmap-pr

optimize x11 display code
go-vgo · Jan 2, 2022 · 108c639 · 108c639
2 parents b270210 + 6c249c1
commit 108c639
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/base/xdisplay_c.h b/base/xdisplay_c.h
@@ -4,11 +4,11 @@
 
 static Display *mainDisplay = NULL;
 static int registered = 0;
+
 static char *displayName = NULL;
 static int hasDisplayNameChanged = 0;
 
-Display *XGetMainDisplay(void)
-{
+Display *XGetMainDisplay(void) {
 	/* Close the display if displayName has changed */
 	if (hasDisplayNameChanged) {
 		XCloseMainDisplay();
@@ -20,7 +20,7 @@ Display *XGetMainDisplay(void)
 		mainDisplay = XOpenDisplay(displayName);
 
 		/* Then try using environment variable DISPLAY */
-		if (mainDisplay == NULL) {
+		if (mainDisplay == NULL && displayName != NULL) {
 			mainDisplay = XOpenDisplay(NULL);
 		}
 
@@ -40,22 +40,19 @@ Display *XGetMainDisplay(void)
 	return mainDisplay;
 }
 
-void XCloseMainDisplay(void)
-{
+void XCloseMainDisplay(void) {
 	if (mainDisplay != NULL) {
 		XCloseDisplay(mainDisplay);
 		mainDisplay = NULL;
 	}
 }
 
-void setXDisplay(char *name)
-{
+void setXDisplay(char *name) {
 	displayName = strdup(name);
 	hasDisplayNameChanged = 1;
 }
 
-char *getXDisplay(void)
-{
+char *getXDisplay(void) {
 	return displayName;
 }
 
diff --git a/robotgo_mac.go → robotgo_mac_unix.go b/robotgo_mac.go → robotgo_mac_unix.go
diff --git a/robotgo_unix.go → robotgo_x11.go b/robotgo_unix.go → robotgo_x11.go