httpbakery/agent: support authinfo in environment variables #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhilton
reviewed
Jan 26, 2018
httpbakery/agent/agent.go
Outdated
| // | ||
| // BAKERY_PUBLIC_KEY='wg/rUMm5cy9O00TaS9pgDIHnFMwhrisI0KDSg4+KkGM=' | ||
| // BAKERY_PRIVATE_KEY='S529MFrVUWB/VqcsPABJSAlnY/57fdHi4cL9HdK9ZQw=' | ||
| // BAKERY_USERS='https://api.jujucharms.com/identity bob https://api.staging.jujucharms.com/identity' |
There was a problem hiding this comment.
This is significantly more complex than I had in mind. I was essentially looking for a fix to juju/charmstore#776. This is not usable that simply. We need to be able to provide API access to jujucharms.com through a mechanism that it "set these two environment variables", "use the tools" type system. The same as people expect from AWS. I'm not interested that we have this crazy bakery setup inside the API that complexity should not be forced onto out users.
rogpeppe
force-pushed
the
143-agent-environment
branch
from
b07485b to
69293eb
Compare
mhilton
approved these changes
Apr 23, 2018
| authInfo1, err := agent.AuthInfoFromEnvironment() | ||
| c.Assert(err, gc.Equals, nil) | ||
| c.Assert(authInfo1, jc.DeepEquals, authInfo) | ||
| } |
There was a problem hiding this comment.
Please also add a test for the error when the environment variable isn't set.
This makes it straightforward for client programs to support agent authentication without needing an explicit command line flag.
rogpeppe
force-pushed
the
143-agent-environment
branch
from
69293eb to
55709bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easy to get agent authinfo from environment
variables instead of a file.