Merge pull request #1 from go-kivik/ci

Configure Travis
go-kivik · Sep 1, 2017 · 323e789 · 323e789
2 parents 0773d91 + ee0a19f
commit 323e789
Show file tree

Hide file tree

Showing 17 changed files with 802 additions and 15 deletions.
diff --git a/.linter.json b/.linter.json
@@ -0,0 +1,6 @@
+{
+    "Enable":   ["gofmt", "vet", "golint", "ineffassign", "vetshadow", "gas", "unparam", "unused", "varcheck"],
+    "Vendor":   true,
+    "Test":     true,
+    "Deadline": "60s"
+}
diff --git a/.linter_test.json b/.linter_test.json
@@ -0,0 +1,7 @@
+{
+    "Enable":   ["errcheck"],
+    "Exclude":  ["_test.go:[0-9]+:[0-9]+:"],
+    "Vendor":   true,
+    "Test":     true,
+    "Deadline": "60s"
+}
diff --git a/.travis.yml b/.travis.yml
@@ -0,0 +1,50 @@
+dist: trusty
+sudo: required
+services:
+    - docker
+addons:
+  apt:
+    sources:
+      - sourceline: 'ppa:masterminds/glide'
+    packages:
+      - glide
+cache:
+    directories:
+        - node_modules
+        - $HOME/gopath/pkg
+        - /var/lib/docker
+
+language: go
+
+os:
+    - linux
+    - osx
+
+go:
+    - 1.7.x
+    - 1.8.x
+    - 1.9.x
+    - master
+env:
+    global:
+        - KIVIK_TEST_DSN_COUCH16="http://admin:abc123@localhost:6000/"
+        - KIVIK_TEST_DSN_COUCH20="http://admin:abc123@localhost:6001/"
+    matrix:
+        - MODE=standard
+
+matrix:
+    allow_failures:
+        - go: master
+    include:
+        - go: 1.9.x
+          os: osx
+        - go: 1.9.x
+          env: MODE=linter
+        - go: 1.9.x
+          env: MODE=coverage
+
+install:
+    - ./travis/install.sh $MODE
+
+script:
+    - ./travis/test.sh $MODE
diff --git a/attachments.go b/attachments.go
@@ -39,7 +39,7 @@ func (d *db) GetAttachmentMeta(ctx context.Context, docID, rev, filename string)
 		return "", driver.MD5sum{}, err
 	}
 	cType, md5sum, body, err := d.decodeAttachment(resp)
-	body.Close()
+	_ = body.Close()
 	return cType, md5sum, err
 }
 

diff --git a/bulk.go b/bulk.go
@@ -70,7 +70,7 @@ func (d *db) BulkDocs(ctx context.Context, docs []interface{}) (driver.BulkResul
 	resp, err := d.Client.DoReq(ctx, kivik.MethodPost, d.path("_bulk_docs", nil), opts)
 	if jsonErr := errFunc(); jsonErr != nil {
 		if resp.Body != nil {
-			resp.Body.Close()
+			_ = resp.Body.Close()
 		}
 		return nil, jsonErr
 	}

diff --git a/codecov.yml b/codecov.yml
@@ -0,0 +1,2 @@
+ignore:
+    - "test/.*"
diff --git a/couchdb.go b/couchdb.go
@@ -11,12 +11,6 @@ import (
 	"github.com/go-kivik/couchdb/chttp"
 )
 
-const (
-	typeJSON  = "application/json"
-	typeText  = "text/plain"
-	typeMixed = "multipart/mixed"
-)
-
 // Couch represents the parent driver instance.
 type Couch struct{}
 

diff --git a/db.go b/db.go
@@ -92,9 +92,11 @@ func (d *db) Get(ctx context.Context, docID string, opts map[string]interface{})
 	if respErr := chttp.ResponseError(resp); respErr != nil {
 		return nil, respErr
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 	doc := &bytes.Buffer{}
-	doc.ReadFrom(resp.Body)
+	if _, err := doc.ReadFrom(resp.Body); err != nil {
+		return nil, err
+	}
 	return doc.Bytes(), nil
 }
 
@@ -155,7 +157,7 @@ func (d *db) Delete(ctx context.Context, docID, rev string) (string, error) {
 	if err != nil {
 		return "", err
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 	return chttp.GetRev(resp)
 }
 
@@ -230,14 +232,14 @@ func (d *db) SetSecurity(ctx context.Context, security *driver.Security) error {
 	res, err := d.Client.DoReq(ctx, kivik.MethodPut, d.path("/_security", nil), opts)
 	if jsonErr := errFunc(); jsonErr != nil {
 		if res != nil && res.Body != nil {
-			res.Body.Close()
+			_ = res.Body.Close()
 		}
 		return jsonErr
 	}
 	if err != nil {
 		return err
 	}
-	defer res.Body.Close()
+	defer func() { _ = res.Body.Close() }()
 	return chttp.ResponseError(res)
 }
 
@@ -263,6 +265,6 @@ func (d *db) Copy(ctx context.Context, targetID, sourceID string, options map[st
 	if err != nil {
 		return "", err
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 	return chttp.GetRev(resp)
 }
diff --git a/glide.yaml b/glide.yaml
@@ -0,0 +1,21 @@
+package: github.com/go-kivik/couchdb
+ignore:
+- github.com/gopherjs/gopherjs
+import:
+- package: github.com/flimzy/kivik
+  version: ^1.0.5
+  subpackages:
+  - driver
+  - driver/util
+  - errors
+- package: github.com/pkg/errors
+  version: ^0.8.0
+- package: golang.org/x/net
+  subpackages:
+  - publicsuffix
+testImport:
+- package: github.com/flimzy/diff
+  version: ^0.1.1
+- package: github.com/go-kivik/kiviktest
+  subpackages:
+  - kt
diff --git a/replication.go b/replication.go
@@ -142,7 +142,7 @@ func (r *replication) updateActiveTasks(ctx context.Context) (*activeTask, error
 	if err = chttp.ResponseError(resp); err != nil {
 		return nil, err
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 	var tasks []*activeTask
 	if err = json.NewDecoder(resp.Body).Decode(&tasks); err != nil {
 		return nil, err

diff --git a/test/cloudant.go b/test/cloudant.go
@@ -0,0 +1,217 @@
+package test
+
+import (
+	"github.com/flimzy/kivik"
+	"github.com/go-kivik/kiviktest"
+	"github.com/go-kivik/kiviktest/kt"
+)
+
+func registerSuiteCloudant() {
+	kiviktest.RegisterSuite(kiviktest.SuiteCloudant, kt.SuiteConfig{
+		"AllDBs.expected":               []string{"_replicator", "_users"},
+		"AllDBs/NoAuth.status":          kivik.StatusUnauthorized,
+		"AllDBs/RW/group/NoAuth.status": kivik.StatusUnauthorized,
+
+		"CreateDB/RW/NoAuth.status":         kivik.StatusUnauthorized,
+		"CreateDB/RW/Admin/Recreate.status": kivik.StatusPreconditionFailed,
+
+		"DestroyDB/RW/Admin/NonExistantDB.status":  kivik.StatusNotFound,
+		"DestroyDB/RW/NoAuth/NonExistantDB.status": kivik.StatusNotFound,
+		"DestroyDB/RW/NoAuth/ExistingDB.status":    kivik.StatusUnauthorized,
+
+		"AllDocs.databases":                  []string{"_replicator", "chicken", "_duck"},
+		"AllDocs/Admin/_replicator.expected": []string{"_design/_replicator"},
+		"AllDocs/Admin/_replicator.offset":   0,
+		"AllDocs/Admin/chicken.status":       kivik.StatusNotFound,
+		"AllDocs/Admin/_duck.status":         kivik.StatusForbidden,
+		"AllDocs/NoAuth/_replicator.status":  kivik.StatusUnauthorized,
+		"AllDocs/NoAuth/chicken.status":      kivik.StatusNotFound,
+		"AllDocs/NoAuth/_duck.status":        kivik.StatusUnauthorized,
+		"AllDocs/RW/group/NoAuth.status":     kivik.StatusUnauthorized,
+
+		"Find.databases":                         []string{"_replicator", "chicken", "_duck"},
+		"Find/Admin/_replicator.expected":        []string{"_design/_replicator"},
+		"Find/Admin/_replicator.offset":          0,
+		"Find/Admin/chicken.status":              kivik.StatusNotFound,
+		"Find/Admin/_duck.status":                kivik.StatusForbidden,
+		"Find/NoAuth/_replicator.status":         kivik.StatusUnauthorized,
+		"Find/NoAuth/chicken.status":             kivik.StatusNotFound,
+		"Find/NoAuth/_duck.status":               kivik.StatusUnauthorized,
+		"Find/RW/group/NoAuth.status":            kivik.StatusUnauthorized,
+		"Find/Admin/_replicator/Warning.warning": "no matching index found, create an index to optimize query time",
+		"Find/RW/group/Admin/Warning.warning":    "no matching index found, create an index to optimize query time",
+		"Find/RW/group/NoAuth/Warning.warning":   "no matching index found, create an index to optimize query time",
+
+		"Query/RW/group/NoAuth.status": kivik.StatusUnauthorized,
+
+		"DBExists.databases":              []string{"_users", "chicken", "_duck"},
+		"DBExists/Admin/_users.exists":    true,
+		"DBExists/Admin/chicken.exists":   false,
+		"DBExists/Admin/_duck.status":     kivik.StatusForbidden,
+		"DBExists/NoAuth/_users.status":   kivik.StatusUnauthorized,
+		"DBExists/NoAuth/_duck.status":    kivik.StatusUnauthorized,
+		"DBExists/NoAuth/chicken.exists":  false,
+		"DBExists/RW/group/Admin.exists":  true,
+		"DBExists/RW/group/NoAuth.status": kivik.StatusUnauthorized,
+
+		"Log/Admin.status":              kivik.StatusForbidden,
+		"Log/NoAuth.status":             kivik.StatusUnauthorized,
+		"Log/Admin/Offset-1000.status":  kivik.StatusBadRequest,
+		"Log/NoAuth/Offset-1000.status": kivik.StatusBadRequest,
+
+		"Version.version":        `^2\.0\.0$`,
+		"Version.vendor":         `^IBM Cloudant$`,
+		"Version.vendor_version": `^\d\d\d\d$`,
+
+		"Get/RW/group/Admin/bogus.status":        kivik.StatusNotFound,
+		"Get/RW/group/NoAuth/bob.status":         kivik.StatusUnauthorized,
+		"Get/RW/group/NoAuth/bogus.status":       kivik.StatusUnauthorized,
+		"Get/RW/group/NoAuth/_design/foo.status": kivik.StatusUnauthorized,
+		"Get/RW/group/NoAuth/_local/foo.status":  kivik.StatusUnauthorized,
+
+		"Rev/RW/group/Admin/bogus.status":        kivik.StatusNotFound,
+		"Rev/RW/group/NoAuth/bob.status":         kivik.StatusUnauthorized,
+		"Rev/RW/group/NoAuth/bogus.status":       kivik.StatusUnauthorized,
+		"Rev/RW/group/NoAuth/_design/foo.status": kivik.StatusUnauthorized,
+		"Rev/RW/group/NoAuth/_local/foo.status":  kivik.StatusUnauthorized,
+
+		"Put/RW/NoAuth/Create.status": kivik.StatusUnauthorized,
+
+		"Flush.databases":                     []string{"_users", "chicken", "_duck"},
+		"Flush/Admin/chicken/DoFlush.status":  kivik.StatusNotFound,
+		"Flush/Admin/_duck/DoFlush.status":    kivik.StatusForbidden,
+		"Flush/NoAuth/chicken/DoFlush.status": kivik.StatusNotFound,
+		"Flush/NoAuth/_users/DoFlush.status":  kivik.StatusUnauthorized,
+		"Flush/NoAuth/_duck/DoFlush.status":   kivik.StatusUnauthorized,
+
+		"Delete/RW/Admin/group/MissingDoc.status":       kivik.StatusNotFound,
+		"Delete/RW/Admin/group/InvalidRevFormat.status": kivik.StatusBadRequest,
+		"Delete/RW/Admin/group/WrongRev.status":         kivik.StatusConflict,
+		"Delete/RW/NoAuth.status":                       kivik.StatusUnauthorized,
+
+		"Session/Get/Admin.info.authentication_handlers":  "delegated,cookie,default,local",
+		"Session/Get/Admin.info.authentication_db":        "_users",
+		"Session/Get/Admin.info.authenticated":            "cookie",
+		"Session/Get/Admin.userCtx.roles":                 "_admin,_reader,_writer",
+		"Session/Get/Admin.ok":                            "true",
+		"Session/Get/NoAuth.info.authentication_handlers": "delegated,cookie,default,local",
+		"Session/Get/NoAuth.info.authentication_db":       "_users",
+		"Session/Get/NoAuth.info.authenticated":           "local",
+		"Session/Get/NoAuth.userCtx.roles":                "",
+		"Session/Get/NoAuth.ok":                           "true",
+
+		"Session/Post/EmptyJSON.status":                               kivik.StatusBadRequest,
+		"Session/Post/BogusTypeJSON.status":                           kivik.StatusBadRequest,
+		"Session/Post/BogusTypeForm.status":                           kivik.StatusBadRequest,
+		"Session/Post/EmptyForm.status":                               kivik.StatusBadRequest,
+		"Session/Post/BadJSON.status":                                 kivik.StatusBadRequest,
+		"Session/Post/BadForm.status":                                 kivik.StatusBadRequest,
+		"Session/Post/MeaninglessJSON.status":                         kivik.StatusInternalServerError,
+		"Session/Post/MeaninglessForm.status":                         kivik.StatusBadRequest,
+		"Session/Post/GoodJSON.status":                                kivik.StatusUnauthorized,
+		"Session/Post/BadQueryParam.status":                           kivik.StatusUnauthorized,
+		"Session/Post/BadCredsJSON.status":                            kivik.StatusUnauthorized,
+		"Session/Post/BadCredsForm.status":                            kivik.StatusUnauthorized,
+		"Session/Post/GoodCredsJSONRemoteRedirHeaderInjection.status": kivik.StatusBadRequest,
+		"Session/Post/GoodCredsJSONRemoteRedirInvalidURL.skip":        true, // Cloudant doesn't sanitize the Location value, so sends unparseable headers.
+
+		"Stats.databases":             []string{"_users", "chicken", "_duck"},
+		"Stats/Admin/chicken.status":  kivik.StatusNotFound,
+		"Stats/Admin/_duck.status":    kivik.StatusForbidden,
+		"Stats/NoAuth/_users.status":  kivik.StatusUnauthorized,
+		"Stats/NoAuth/chicken.status": kivik.StatusNotFound,
+		"Stats/NoAuth/_duck.status":   kivik.StatusUnauthorized,
+		"Stats/RW/NoAuth.status":      kivik.StatusUnauthorized,
+
+		"CreateDoc/RW/group/NoAuth.status": kivik.StatusUnauthorized,
+
+		"Compact/RW/Admin.status":  kivik.StatusForbidden,
+		"Compact/RW/NoAuth.status": kivik.StatusUnauthorized,
+
+		"ViewCleanup/RW/Admin.status":  kivik.StatusForbidden,
+		"ViewCleanup/RW/NoAuth.status": kivik.StatusUnauthorized,
+
+		"Security.databases":                    []string{"_replicator", "_users", "_global_changes", "chicken", "_duck"},
+		"Security/Admin/_global_changes.status": kivik.StatusForbidden,
+		"Security/Admin/chicken.status":         kivik.StatusNotFound,
+		"Security/Admin/_duck.status":           kivik.StatusForbidden,
+		"Security/NoAuth.status":                kivik.StatusUnauthorized,
+		"Security/NoAuth/chicken.status":        kivik.StatusNotFound,
+		"Security/NoAuth/_duck.status":          kivik.StatusUnauthorized,
+		"Security/RW/group/NoAuth.status":       kivik.StatusUnauthorized,
+
+		"SetSecurity/RW/Admin/NotExists.status":  kivik.StatusNotFound,
+		"SetSecurity/RW/NoAuth/NotExists.status": kivik.StatusNotFound,
+		"SetSecurity/RW/NoAuth/Exists.status":    kivik.StatusUnauthorized,
+
+		"DBUpdates/RW/Admin.status":  kivik.StatusNotFound, // Cloudant apparently disables this
+		"DBUpdates/RW/NoAuth.status": kivik.StatusUnauthorized,
+
+		"Changes/RW/group/NoAuth.status": kivik.StatusUnauthorized,
+
+		"Copy/RW/group/NoAuth.status": kivik.StatusUnauthorized,
+
+		"BulkDocs/RW/NoAuth.status":                    kivik.StatusUnauthorized,
+		"BulkDocs/RW/NoAuth/group/Mix/Conflict.status": kivik.StatusConflict,
+		"BulkDocs/RW/Admin/group/Mix/Conflict.status":  kivik.StatusConflict,
+
+		"GetAttachment/RW/group/Admin/foo/NotFound.status": kivik.StatusNotFound,
+		"GetAttachment/RW/group/NoAuth.status":             kivik.StatusUnauthorized,
+
+		"GetAttachmentMeta/RW/group/Admin/foo/NotFound.status": kivik.StatusNotFound,
+		"GetAttachmentMeta/RW/group/NoAuth.status":             kivik.StatusUnauthorized,
+
+		"PutAttachment/RW/group/Admin/Conflict.status": kivik.StatusInternalServerError, // COUCHDB-3361
+		"PutAttachment/RW/group/NoAuth.status":         kivik.StatusUnauthorized,
+
+		// "DeleteAttachment/RW/group/Admin/NotFound.status":  kivik.StatusNotFound, // COUCHDB-3362
+		"DeleteAttachment/RW/group/NoAuth.status":       kivik.StatusUnauthorized,
+		"DeleteAttachment/RW/group/Admin/NoDoc.status":  kivik.StatusInternalServerError,
+		"DeleteAttachment/RW/group/NoAuth/NoDoc.status": kivik.StatusUnauthorized,
+
+		"Put/RW/Admin/group/LeadingUnderscoreInID.status": kivik.StatusBadRequest,
+		"Put/RW/Admin/group/Conflict.status":              kivik.StatusConflict,
+		"Put/RW/NoAuth/group.status":                      kivik.StatusUnauthorized,
+		"Put/RW/NoAuth/group/Conflict.skip":               true,
+
+		"CreateIndex/RW/Admin/group/EmptyIndex.status":    kivik.StatusBadRequest,
+		"CreateIndex/RW/Admin/group/BlankIndex.status":    kivik.StatusBadRequest,
+		"CreateIndex/RW/Admin/group/InvalidIndex.status":  kivik.StatusBadRequest,
+		"CreateIndex/RW/Admin/group/NilIndex.status":      kivik.StatusBadRequest,
+		"CreateIndex/RW/Admin/group/InvalidJSON.status":   kivik.StatusBadRequest,
+		"CreateIndex/RW/NoAuth/group/EmptyIndex.status":   kivik.StatusUnauthorized,
+		"CreateIndex/RW/NoAuth/group/BlankIndex.status":   kivik.StatusBadRequest,
+		"CreateIndex/RW/NoAuth/group/InvalidIndex.status": kivik.StatusUnauthorized,
+		"CreateIndex/RW/NoAuth/group/NilIndex.status":     kivik.StatusUnauthorized,
+		"CreateIndex/RW/NoAuth/group/InvalidJSON.status":  kivik.StatusBadRequest,
+		"CreateIndex/RW/NoAuth/group/Valid.status":        kivik.StatusUnauthorized,
+
+		"GetIndexes.databases":                     []string{"_replicator", "_users", "_global_changes", "chicken", "_duck"},
+		"GetIndexes/Admin/_replicator.indexes":     []kivik.Index{kt.AllDocsIndex},
+		"GetIndexes/Admin/_users.indexes":          []kivik.Index{kt.AllDocsIndex},
+		"GetIndexes/Admin/_global_changes.status":  kivik.StatusForbidden,
+		"GetIndexes/Admin/chicken.status":          kivik.StatusNotFound,
+		"GetIndexes/Admin/_duck.status":            kivik.StatusForbidden,
+		"GetIndexes/NoAuth/_replicator.indexes":    []kivik.Index{kt.AllDocsIndex},
+		"GetIndexes/NoAuth/_users.indexes":         []kivik.Index{kt.AllDocsIndex},
+		"GetIndexes/NoAuth/_global_changes.status": kivik.StatusForbidden,
+		"GetIndexes/NoAuth/chicken.status":         kivik.StatusNotFound,
+		"GetIndexes/NoAuth/_duck.status":           kivik.StatusForbidden,
+		"GetIndexes/RW/NoAuth.status":              kivik.StatusUnauthorized,
+
+		"DeleteIndex/RW/Admin/group/NotFoundDdoc.status": kivik.StatusNotFound,
+		"DeleteIndex/RW/Admin/group/NotFoundName.status": kivik.StatusNotFound,
+		"DeleteIndex/RW/NoAuth.status":                   kivik.StatusUnauthorized,
+
+		"GetReplications/NoAuth.status": kivik.StatusUnauthorized,
+
+		"Replicate.NotFoundDB":                                  "http://localhost:5984/foo",
+		"Replicate.timeoutSeconds":                              300,
+		"Replicate/RW/NoAuth.status":                            kivik.StatusUnauthorized,
+		"Replicate/RW/Admin/group/MissingSource/Results.status": kivik.StatusInternalServerError,
+		"Replicate/RW/Admin/group/MissingTarget/Results.status": kivik.StatusInternalServerError,
+
+		"Query/RW/group/Admin/WithoutDocs/ScanDoc.status":  kivik.StatusBadRequest,
+		"Query/RW/group/NoAuth/WithoutDocs/ScanDoc.status": kivik.StatusBadRequest,
+	})
+}