Refactor GenerateSignature
to eliminate manual RSA private encryption implementation
#257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There is a manual implementation of RSA private encryption in the codebase, which is generally not recommended.
RSA Private Encryption
Mixlib::Authentication uses Ruby's OpenSSL::PKey::RSA.private_encrypt method to “encrypt” version 1.0 headers.
It is essentially an RSA signing operation with PKCS1v15 padding and no digest, so we can simply use
rsa.SignPKCS1v15
to “encrypt” (actually sign) the version 1.0 headers.Equivalent Table
1.0
Ruby
OpenSSL CLI
Go
1.3
Ruby
OpenSSL CLI
Go
This PR
rsa.SignPKCS1v15
signature10
andsignature13
are generated with ruby's RSA module.)