-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Change @sym to a classdef. #590
base: master
Are you sure you want to change the base?
Changes from 6 commits
ac27887
7235925
f713b30
ee65900
67c865a
ff299ae
24817dd
416c83c
400164b
d98a54e
e7b4f75
e0851d7
ba12a0e
336eddf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,7 +65,7 @@ | |
|
||
% Note: symbolic sized matrices should return double, not sym/string. | ||
|
||
n = x.size; | ||
n = x.symsize; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was required. Because if I used There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is that because |
||
|
||
% FIXME: for now, we artificially force symbolic sized objects | ||
% (where one or more dimension is recorded as NaN) to be 1x1. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented out the tests in all the private function files because I use
runtests
command to run the tests in a directory and it tries to run the tests in these files too resulting in error. I hope it's ok.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this is unavoidable if we move them out of
private/
. This is b/c runtests and doctest are currently based on directory listings notmethods
calls.