Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with BSD tar by supporting both tar and gtar #1316

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

Sonu0305
Copy link
Contributor

This PR addresses the issue (#1315) with packaging and tarball creation on systems using BSD tar. On such systems, the default tar command may not work as expected, and GNU tar (gtar) is required instead.

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Nov 30, 2024

Hi @cbm755 ,
I kindly request if you could review the pull request. Please let me know if any further changes or adjustments are needed.
Thank you for your time and support!

@cbm755
Copy link
Collaborator

cbm755 commented Dec 1, 2024

Looks good to me! This seems familiar, maybe something that has come up in other Octave packages... If you have a moment, can you also check https://github.com/gnu-octave/octave-doctest? maybe image and interval too? IIRC, the Makefile was pretty common...

@cbm755 cbm755 merged commit fde3f12 into gnu-octave:main Dec 1, 2024
31 checks passed
@Sonu0305 Sonu0305 deleted the fix#1315 branch December 1, 2024 07:11
@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Dec 1, 2024

Looks good to me! This seems familiar, maybe something that has come up in other Octave packages... If you have a moment, can you also check https://github.com/gnu-octave/octave-doctest? maybe image and interval too? IIRC, the Makefile was pretty common...

@cbm755
For octave-doctest:
The Makefile for doctest also sets up support for tar, but in a slightly different way. It attempts to find gtar (GNU tar) first and, if not found, defaults to using the system tar. This is done through the line:

TAR := $(shell which gtar 2>/dev/null || echo tar)

Do you want me to modify the doctest Makefile to use the same method as in symbolic's Makefile, where the TAR variable is not prioritized (just uses whatever tar is available in the environment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants