Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1846 refactor gnft #443

Merged
merged 37 commits into from
Dec 27, 2024
Merged

GSW-1846 refactor gnft #443

merged 37 commits into from
Dec 27, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Dec 17, 2024 •
edited
Loading

Description

  • refactor: apply ownable package to check caller's privileges
  • refactor: use avl.Tree instead of map
  • feat: checkErr checks error then panic if err being return
  • docs: comments for every function
  • fix: return error while setting token uri
  • test: cover all functions

image

@r3v4s r3v4s requested review from notJoon and onlyhyde December 17, 2024 08:24
@r3v4s r3v4s self-assigned this Dec 17, 2024
notJoon
notJoon previously approved these changes Dec 17, 2024
View reviewed changes
notJoon
notJoon previously approved these changes Dec 19, 2024
View reviewed changes
dongwon8247
dongwon8247 reviewed Dec 19, 2024
View reviewed changes
_deploy/r/gnoswap/gnft/gnft.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/gnft.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/gnft.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/gnft.gno Outdated Show resolved Hide resolved
onlyhyde
onlyhyde requested changes Dec 20, 2024
View reviewed changes
_deploy/r/gnoswap/gnft/gnft.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/gnft.gno Show resolved Hide resolved
_deploy/r/gnoswap/gnft/gnft.gno Show resolved Hide resolved
_deploy/r/gnoswap/gnft/gnft.gno Show resolved Hide resolved
_deploy/r/gnoswap/gnft/utils.gno Show resolved Hide resolved
_deploy/r/gnoswap/gnft/gnft.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/gnft.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/gnft.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/gnft.gno Outdated Show resolved Hide resolved
_deploy/r/gnoswap/gnft/gnft.gno Outdated Show resolved Hide resolved
onlyhyde
onlyhyde requested changes Dec 20, 2024
View reviewed changes
_deploy/r/gnoswap/gnft/gnft.gno Outdated Show resolved Hide resolved
notJoon
notJoon previously approved these changes Dec 20, 2024
View reviewed changes
@onlyhyde onlyhyde self-requested a review December 23, 2024 11:07
notJoon
notJoon previously approved these changes Dec 23, 2024
View reviewed changes
@onlyhyde
Copy link
Member

The implementation has been updated in the form of the GRC721 interface.
https://gno.land/p/demo/grc/grc721/$source&file=igrc721.gno

r3v4s and others added 26 commits December 27, 2024 14:58
@r3v4s @onlyhyde
docs: add comments
1bbe6ab
@r3v4s @onlyhyde
chore
6c34725
@r3v4s @onlyhyde
test: update testcase
d728830
@r3v4s @onlyhyde
fix: use predefined error variable
aa1f881
@r3v4s @onlyhyde
chore: clear variable naming
bf09c0c
@r3v4s @onlyhyde
fix: SetTokenURILast should only handle last minted token
2a7c41d
@r3v4s @onlyhyde
refactor: declare variable type first, then initalize it
ddf8693
@r3v4s @onlyhyde
test: fix testcase
f64b0c0
@r3v4s @onlyhyde
fix: typo
22aa220
@r3v4s @dongwon8247 @onlyhyde
Update _deploy/r/gnoswap/gnft/gnft.gno
a5e28ea 
Co-authored-by: Dongwon <[email protected]>
@r3v4s @dongwon8247 @onlyhyde
Update _deploy/r/gnoswap/gnft/gnft.gno
7feab6c 
Co-authored-by: Dongwon <[email protected]>
@r3v4s @dongwon8247 @onlyhyde
Update _deploy/r/gnoswap/gnft/gnft.gno
babba13 
Co-authored-by: Dongwon <[email protected]>
@r3v4s @onlyhyde
Update _deploy/r/gnoswap/gnft/gnft.gno
4526596 
Co-authored-by: 0xTopaz <[email protected]>
@r3v4s @onlyhyde
chore: comments
bbb189d
@r3v4s @onlyhyde
feat: private setTokenURI to generate and set uri
b66d925
@r3v4s @onlyhyde
feat: removeTokenList
20b2088
@r3v4s @onlyhyde
fix: append/remove token id from list
80e0fda
@r3v4s @onlyhyde
fix: mismatch type
c36e068
@r3v4s @onlyhyde
feat: check permission before excuting actual logic
e732335
@r3v4s @onlyhyde
test: update more cases
25263c9
@r3v4s @onlyhyde
chore
f92b8a0
@r3v4s @onlyhyde
feat: SafeTransferFrom place holder function to satisfy igrc721
f28139d
@r3v4s @onlyhyde
feat: check from and to address is valid or not
0183320
@r3v4s @onlyhyde
fix: prevent overwrite of tokenURI
1d58894
@r3v4s @onlyhyde
chore: SafeTransferFrom calls TransferFrom
229663c 
- current TransferFrom has all safe logics
@onlyhyde
refactor: support grc721 interface
3063a24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@onlyhyde onlyhyde merged commit 3433e61 into main Dec 27, 2024
2 checks passed
@onlyhyde onlyhyde deleted the refactor/gnft branch December 27, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwon8247 dongwon8247 dongwon8247 left review comments

@onlyhyde onlyhyde onlyhyde approved these changes

@notJoon notJoon notJoon approved these changes

Assignees

@r3v4s r3v4s

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r3v4s @onlyhyde @notJoon @dongwon8247