refactor: router #431
Merged
refactor: router #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongwon8247
reviewed
Dec 11, 2024
dongwon8247
reviewed
Dec 12, 2024
There was a problem hiding this comment.
@notJoon Please add a unit test for swap_multi.gno, swap_single.gno and wrap_unwrap.gno.
Functions that use Pool currently doesn't have tests yet. This is because there's no way to directly access and initialize the pool's state for now.
Can you create mockup data in pool that you can use for testing purposes in router? This seems essential tests. Think about a way to complete tests for this please.
notJoon
commented
Dec 16, 2024
r3v4s
reviewed
Dec 16, 2024
r3v4s
reviewed
Dec 16, 2024
r3v4s
reviewed
Dec 16, 2024
r3v4s
reviewed
Dec 16, 2024
r3v4s
reviewed
Dec 16, 2024
Co-authored-by: Blake <[email protected]>
modified to avoid continuing to use raw strings and add parsing functions to convert to proper types
- replaces previous token_register pattern
onlyhyde
force-pushed
the
router-refact
branch
from
eea799b to
d1a5e11
Compare
onlyhyde
previously approved these changes
Dec 27, 2024
|
onlyhyde
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
routefile mainly.Remove
compute_routesandgno_helperfiles_swapfunctions and renamed them toswapInnerDrySwapRoutefunction and related methodsUpdate
"EXACT_IN","EXACT_OUT"strings. Additionally replace other hardcoded values with constants_helper_testfile for testing purposeFunctions that use
Poolcurrently doesn't have tests yet. This is because there's no way to directly access and initialize the pool's state for now.