Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

2624/add cow to swap modal #2647

Closed
wants to merge 3 commits into from
Closed

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Apr 1, 2022

Summary

Fixes #2624

  • adds COW to common tokens list
  • moves COW up the token list

@nenadV91 nenadV91 requested review from a team April 1, 2022 13:17
return 0
}

function getTokenComparator(balances: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't this exist somewhere already? or did u just move this and mod it a bit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It exists, this is mod

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's worth making a const list of tokens we'd like to prioritise listed in order of importance

e.g const PRIORITISED_TOKENS = [COW, GNO] where lower index = higher prio

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of line 33

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 👍

@W3stside
Copy link
Contributor

W3stside commented Apr 1, 2022

nice small PR! thank you!! will review in depth a little later

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

elena-zh commented Apr 1, 2022

Hey @nenadV91 , great!
The only thing I can mention, that we do not have this token in the list for Rinkeby
image

@nenadV91 nenadV91 requested a review from W3stside April 1, 2022 14:36
@nenadV91
Copy link
Contributor Author

nenadV91 commented Apr 1, 2022

@elena-zh I think we should do that in a separate PR since its not related to this issue.

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

@stale stale bot added the wontfix Stale issue label Jun 12, 2022
@stale stale bot closed this Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix Stale issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add COW token to common token lists in swap modal
3 participants