-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
return 0 | ||
} | ||
|
||
function getTokenComparator(balances: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't this exist somewhere already? or did u just move this and mod it a bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It exists, this is mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it's worth making a const list of tokens we'd like to prioritise listed in order of importance
e.g const PRIORITISED_TOKENS = [COW, GNO]
where lower index = higher prio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of line 33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 👍
nice small PR! thank you!! will review in depth a little later |
|
Hey @nenadV91 , great! |
@elena-zh I think we should do that in a separate PR since its not related to this issue. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Summary
Fixes #2624