Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2624/add cow to swap modal #359

Merged
merged 3 commits into from
Apr 4, 2022
Merged

2624/add cow to swap modal #359

merged 3 commits into from
Apr 4, 2022

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Apr 4, 2022

Summary

Fixes #337

  • adds COW to common tokens list
  • moves COW up the token list

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@nenadV91 nenadV91 requested review from a team April 4, 2022 09:21
@elena-zh elena-zh mentioned this pull request Apr 4, 2022
Closed
elena-zh
elena-zh approved these changes Apr 4, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nenadV91 , changes LGTM!
I have created a separate issue about adding CowProtocol tokens to the Rinkeby network, so the COW token will appear in the list after that changes.
Thanks

@nenadV91 nenadV91 changed the base branch from develop to release/1.13 April 4, 2022 13:26
@nenadV91 nenadV91 merged commit 3681563 into release/1.13 Apr 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2022
@nenadV91 nenadV91 deleted the 2624/add-cow-to-swap-modal branch June 14, 2022 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

@fairlighteth fairlighteth fairlighteth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add COW token to common token lists in swap modal
3 participants
@nenadV91 @fairlighteth @elena-zh