chore: cleanup gno files #3527
Merged
chore: cleanup gno files #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR mostly removes some unused variables and type assertions that should have been identified by `golang` at compile time. These errors were flagged by `gnopls`, and I'm unsure why they weren't detected earlier. We have a way to identify them using our own `gno` tools. Signed-off-by: gfanton <[email protected]>
github-actions
bot
added
the
🧾 package/realm
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
|
Seems this is also unused: |
leohhhn
approved these changes
Jan 19, 2025
thehowl
approved these changes
Jan 20, 2025
|
These are not caught by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly removes some unused variables and type assertions that should have been identified by
golangas error at compile time. These errors were flagged bygnopls, and I'm unsure why they are not currently detected as error by our currentgnotools suite.