-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: experimental render proxy example for versioned realms #3341
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
@moul this is the simple pattern that we are using for Gno.me to be able to support multiple realm versions while keeping the same URL for rendering content. Instead of merging this example we could have a couple of tutorials in Gno.me explaining different patterns to version realms. The patterns could be the ones that you wrote plus this one. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Co-authored-by: Leon Hudak <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good by itself, though I'm beginning to think that maybe we should move all x/
realms into simple realms in personal namespaces.
It would make sense |
This a push and pray because the CI is selective, but merging this and creating an issue. |
This example shows how proxying render calls can be used to allow updating realms to new versions while keeping the same realm path. The idea is to have a simple "parent" realm that only keeps track of the latest realm version and forwards all render calls to it. --------- Co-authored-by: Nathan Toups <[email protected]> Co-authored-by: Leon Hudak <[email protected]> Co-authored-by: Morgan <[email protected]>
This example shows how proxying render calls can be used to allow updating realms to new versions while keeping the same realm path. The idea is to have a simple "parent" realm that only keeps track of the latest realm version and forwards all render calls to it.