-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: min gas prices config #3340
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and simple 💯
Left a few minor comments, but nothing blocking. Feel free to merge 🚀
The minimum gas price configuration is a mechanism to prevent spam and ensure that only transactions with sufficient fees are processed. It achieves this by setting a minimum cost per unit of gas that a transaction must meet to be included in the mempool.
The following condition is checked by the validator: the gas and fees provided by the user must meet this condition before the transaction can be included in the mempool and subsequently processed by the VM.
Gas Fee => Gas Wanted x Min Gas Prices
A node operator can set the min gas prices as following
gnoland config set application.min_gas_prices "1000ugnot/1gas"