Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some function names in comment #3322

Closed
wants to merge 1 commit into from
+3 −3
Closed

chore: fix some function names in comment #3322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tm2/pkg/bft/rpc/lib/server/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ func (wsc *wsConnection) GetRemoteAddr() string {
return wsc.remoteAddr
}

// WriteRPCResponse pushes a response to the writeChan, and blocks until it is accepted.
// WriteRPCResponses pushes a response to the writeChan, and blocks until it is accepted.
// It implements WSRPCConnection. It is Goroutine-safe.
func (wsc *wsConnection) WriteRPCResponses(resp types.RPCResponses) {
select {
Expand All @@ -623,7 +623,7 @@ func (wsc *wsConnection) WriteRPCResponses(resp types.RPCResponses) {
}
}

// TryWriteRPCResponse attempts to push a response to the writeChan, but does not block.
// TryWriteRPCResponses attempts to push a response to the writeChan, but does not block.
// It implements WSRPCConnection. It is Goroutine-safe
func (wsc *wsConnection) TryWriteRPCResponses(resp types.RPCResponses) bool {
select {
Expand Down
2 changes: 1 addition & 1 deletion tm2/pkg/crypto/ledger/ledger_secp256k1.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ func getPubKeyUnsafe(device ledger.SECP256K1, path hd.BIP44Params) (crypto.PubKe
return compressedPublicKey, nil
}

// getPubKeyAddr reads the pubkey and the address from a ledger device.
// getPubKeyAddrSafe reads the pubkey and the address from a ledger device.
// This function is marked as Safe as it will require user confirmation and
// account and index will be shown in the device.
//
Expand Down
Loading