Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: r/demo/games/ga #3208

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

feat: r/demo/games/ga #3208

wants to merge 8 commits into from

Conversation

ltzmaxwell
Copy link
Contributor

@ltzmaxwell ltzmaxwell commented Nov 26, 2024 •
edited
Loading

An Genetic Algorithm demo, can be regarded as a use case of r/demo/entropy.
Maybe should be moved to some other namespace.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Nov 26, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@leohhhn leohhhn self-requested a review November 26, 2024 14:15
leohhhn
leohhhn reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ltzmaxwell

Please check the CI. Also, I think this could be made a bit more interactive and it could stay under the games/ subfolder. Maybe think about creating a Render function that could allow users to modify the target, etc.

examples/gno.land/r/demo/games/ga/ga.gno

// Step 3: Check for Solution
best := findBestIndividual(population)
//fmt.Printf("Generation %d: %s (Fitness: %f)\n", generation, best.Genome, best.Fitness)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover?

examples/gno.land/r/demo/games/ga/z0_filetest.gno
)

func main() {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra newline

@Kouteki Kouteki added the in focus Core team is prioritizing this work label Nov 27, 2024
thehowl
thehowl approved these changes Nov 27, 2024
View reviewed changes
examples/gno.land/r/demo/games/ga/ga.gno
"math"

"gno.land/p/demo/entropy"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can make this have a Render function?

@thehowl thehowl marked this pull request as draft January 16, 2025 14:52
@thehowl
Copy link
Member

thehowl commented Jan 16, 2025

Converting to draft, feel free to undraft once changes are applied / reviewed.

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 16, 2025 •
edited
Loading

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: ltzmaxwell/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leohhhn leohhhn leohhhn left review comments

@thehowl thehowl thehowl approved these changes

Assignees

@ltzmaxwell ltzmaxwell

Labels
in focus Core team is prioritizing this work 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
🧙‍♂️gno.land core team
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ltzmaxwell @thehowl @Gno2D2 @leohhhn @Kouteki