Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnovm): add software floating point package #2863

Closed
wants to merge 2 commits into from

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Sep 27, 2024

Based on the runtime softfloat64.go file.

Fixes #312 .

Still WIP, need to include it into the source code for the GnoVM.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@thehowl thehowl self-assigned this Sep 27, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 67.30310% with 137 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../gnolang/internal/softfloat/runtime_softfloat64.go 70.72% 108 Missing and 5 partials ⚠️
gnovm/pkg/gnolang/internal/softfloat/softfloat.go 27.27% 24 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thehowl thehowl added this to the 🚀 Mainnet launch milestone Nov 6, 2024
@thehowl thehowl added the in focus Core team is prioritizing this work label Nov 6, 2024
@Kouteki Kouteki removed the in focus Core team is prioritizing this work label Nov 19, 2024
@thehowl
Copy link
Member Author

thehowl commented Nov 26, 2024

Superseded by #3185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Test and document floating point determinsm
3 participants