Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gno mod accepts invalid module names #3493

Open
kristovatlas opened this issue Jan 13, 2025 · 0 comments · May be fixed by #3526
Open

gno mod accepts invalid module names #3493

kristovatlas opened this issue Jan 13, 2025 · 0 comments · May be fixed by #3526
Assignees
Labels
🐞 bug Something isn't working

Comments

@kristovatlas
Copy link
Contributor

kristovatlas commented Jan 13, 2025

Validation of module names by gno mod is weak

Description

gno mod does not appear to apply the same level of strict validation of module names as go mod does.

% cat gno.mod
module �xample.com/myproject

go 1.20
% gno mod tidy
% cat go.mod
module �xample.com/myproject

go 1.20
% go mod tidy
go: malformed module path "�xample.com/myproject": invalid char ''

Your environment

  • Go version (example: go1.22.4): go version go1.23.4 darwin/arm64
  • OS and CPU architecture (example: linux/amd64): darwin/arm64
  • Gno commit hash causing the issue (example: f24690e): 36c8f0e

Steps to reproduce

  • Tell us how to reproduce this issue

See above sample modfile

  • Where the issue is, if you know
  • Which commands triggered the issue, if any

See above

Expected behaviour

Tell us what should happen

gno mod should return error similar to go mod

Actual behaviour

Tell us what happens instead

Logs

Please paste any logs here that demonstrate the issue, if they exist

Proposed solution

If you have an idea of how to fix this issue, please write it down here, so we can begin discussing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants