-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task: check the lexical restrictions on gno module paths and compare to go #2426
Comments
@kristovatlas any chance we can get this rolling in the next few days? |
Ok so the lexical restrictions on gno.mod aren't documented anywhere I can find, but the code is fairly copy/pasted over from Go. Because of the complexity of the code, I don't think I'll tease out the differences with additional manual review, so my next step will be to write a little fuzzer that mutates a sample file and runs them through |
The relevant files: https://github.com/golang/mod/blob/master/modfile/read.go parses the file into AST https://github.com/gnolang/gno/blob/master/gnovm/pkg/gnomod/read.go combines functions from both of these |
Working on a simple fuzzing tool revealed the following issue: #3493 |
This is the fuzzing tool: https://github.com/kristovatlas/gno-fuzz-comparer |
Why is this "security" and "mainnet beta launch" when gno.mod files are not even used or published on-chain? |
It should not be labeled as "mainnet beta launch." Although it may be difficult to identify a scenario where this poses a security concern, it can indeed be one. I would categorize it as "low-impact security," which is not among our current priorities. |
Bumped milestone to post-mainnet. |
Description
https://go.dev/ref/mod#go-mod-file-ident
The text was updated successfully, but these errors were encountered: