Skip to content

Commit

Permalink
ci: benchmark only BenchmarkBenchdata (#3007)
Browse files Browse the repository at this point in the history
A bit radical, but I'm open to other benchmarks we should include.

Essentially, in an effort to have a small amount of meaningful
benchmarks, I'd like for these to only be those in BenchmarkBenchdata.
Yes, I recognize this is tooting my own horn, but I think they are good
benchmarks that tell us, overall, if the GnoVM on a few reference
programs got slower or faster, and I found them useful in the past while
doing manual execution.

Most other benchmarks are micro-benchmarks, which aren't likely to
change often or to give us useful insight. I'm open to suggestions for
others that make sense to be tracked, but I think it's for the better if
we keep the number low so the CI for benchmarks can run in just a few
minutes.
  • Loading branch information
thehowl authored Oct 25, 2024
1 parent 49e718c commit cfbaff2
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/benchmark-master-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,12 @@ jobs:
go-version: "1.22.x"

- name: Run benchmark
# add more benchmarks by adding additional lines for different packages;
# or modify the -bench regexp.
run: |
go test -benchmem -bench=. ./... -run=^$ \
-cpu 1,2 -timeout 50m | tee benchmarks.txt
set -xeuo pipefail && (
go test ./gnovm/pkg/gnolang -bench='BenchmarkBenchdata' -benchmem -run='^$' -v -cpu=1,2
) | tee benchmarks.txt
- name: Download previous benchmark data
uses: actions/cache@v4
Expand Down

0 comments on commit cfbaff2

Please sign in to comment.