fix(simpledao): reject invalid voting options (#3077)

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
</details>

examples/gno.land/p/demo/simpledao/propstore.gno

@@ -71,7 +71,7 @@ func (p *proposal) Render() string {
 	output += ufmt.Sprintf("Status: %s", p.Status().String())
 	output += "\n\n"
 	output += ufmt.Sprintf(
-		"Voting stats: YAY %d (%d%%), NAY %d (%d%%), ABSTAIN %d (%d%%), HAVEN'T VOTED %d (%d%%)",
+		"Voting stats: YES %d (%d%%), NO %d (%d%%), ABSTAIN %d (%d%%), MISSING VOTE %d (%d%%)",
 		stats.YayVotes,
 		stats.YayPercent(),
 		stats.NayVotes,

examples/gno.land/p/demo/simpledao/votestore.gno

@@ -2,6 +2,7 @@ package simpledao
 
 import (
 	"errors"
+	"strings"
 
 	"gno.land/p/demo/avl"
 	"gno.land/p/demo/dao"
@@ -38,14 +39,19 @@ func (t *tally) castVote(member membstore.Member, option dao.VoteOption) error {
 		return ErrAlreadyVoted
 	}
 
+	// convert option to upper-case, like the constants are.
+	option = dao.VoteOption(strings.ToUpper(string(option)))
+
 	// Update the tally
 	switch option {
 	case dao.YesVote:
 		t.yays += member.VotingPower
 	case dao.AbstainVote:
 		t.abstains += member.VotingPower
-	default:
+	case dao.NoVote:
 		t.nays += member.VotingPower
+	default:
+		panic("invalid voting option: " + option)
 	}
 
 	// Save the voting status

examples/gno.land/r/gov/dao/v2/prop1_filetest.gno

@@ -84,7 +84,7 @@ func main() {
 //
 // Status: active
 //
-// Voting stats: YAY 0 (0%), NAY 0 (0%), ABSTAIN 0 (0%), HAVEN'T VOTED 10 (100%)
+// Voting stats: YES 0 (0%), NO 0 (0%), ABSTAIN 0 (0%), MISSING VOTE 10 (100%)
 //
 // Threshold met: false
 //
@@ -99,7 +99,7 @@ func main() {
 //
 // Status: accepted
 //
-// Voting stats: YAY 10 (100%), NAY 0 (0%), ABSTAIN 0 (0%), HAVEN'T VOTED 0 (0%)
+// Voting stats: YES 10 (100%), NO 0 (0%), ABSTAIN 0 (0%), MISSING VOTE 0 (0%)
 //
 // Threshold met: true
 //
@@ -116,7 +116,7 @@ func main() {
 //
 // Status: execution successful
 //
-// Voting stats: YAY 10 (100%), NAY 0 (0%), ABSTAIN 0 (0%), HAVEN'T VOTED 0 (0%)
+// Voting stats: YES 10 (100%), NO 0 (0%), ABSTAIN 0 (0%), MISSING VOTE 0 (0%)
 //
 // Threshold met: true
 //

examples/gno.land/r/gov/dao/v2/prop2_filetest.gno

@@ -61,7 +61,7 @@ func main() {
 //
 // Status: active
 //
-// Voting stats: YAY 0 (0%), NAY 0 (0%), ABSTAIN 0 (0%), HAVEN'T VOTED 10 (100%)
+// Voting stats: YES 0 (0%), NO 0 (0%), ABSTAIN 0 (0%), MISSING VOTE 10 (100%)
 //
 // Threshold met: false
 //
@@ -76,7 +76,7 @@ func main() {
 //
 // Status: accepted
 //
-// Voting stats: YAY 10 (100%), NAY 0 (0%), ABSTAIN 0 (0%), HAVEN'T VOTED 0 (0%)
+// Voting stats: YES 10 (100%), NO 0 (0%), ABSTAIN 0 (0%), MISSING VOTE 0 (0%)
 //
 // Threshold met: true
 //
@@ -95,7 +95,7 @@ func main() {
 //
 // Status: execution successful
 //
-// Voting stats: YAY 10 (100%), NAY 0 (0%), ABSTAIN 0 (0%), HAVEN'T VOTED 0 (0%)
+// Voting stats: YES 10 (100%), NO 0 (0%), ABSTAIN 0 (0%), MISSING VOTE 0 (0%)
 //
 // Threshold met: true
 //

examples/gno.land/r/gov/dao/v2/prop3_filetest.gno

@@ -75,7 +75,7 @@ func main() {
 //
 // Status: active
 //
-// Voting stats: YAY 0 (0%), NAY 0 (0%), ABSTAIN 0 (0%), HAVEN'T VOTED 10 (100%)
+// Voting stats: YES 0 (0%), NO 0 (0%), ABSTAIN 0 (0%), MISSING VOTE 10 (100%)
 //
 // Threshold met: false
 //
@@ -90,7 +90,7 @@ func main() {
 //
 // Status: accepted
 //
-// Voting stats: YAY 10 (100%), NAY 0 (0%), ABSTAIN 0 (0%), HAVEN'T VOTED 0 (0%)
+// Voting stats: YES 10 (100%), NO 0 (0%), ABSTAIN 0 (0%), MISSING VOTE 0 (0%)
 //
 // Threshold met: true
 //
@@ -108,7 +108,7 @@ func main() {
 //
 // Status: execution successful
 //
-// Voting stats: YAY 10 (25%), NAY 0 (0%), ABSTAIN 0 (0%), HAVEN'T VOTED 30 (75%)
+// Voting stats: YES 10 (25%), NO 0 (0%), ABSTAIN 0 (0%), MISSING VOTE 30 (75%)
 //
 // Threshold met: false
 //