Curtain instant #1450
Open
Curtain instant #1450
+1,003
−655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
midas-myth
commented
Dec 12, 2024
•
midas-myth
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1208887330734369
✅ Deploy Preview for vigilant-albattani-df38ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying gmx-interface with
|
| Latest commit: |
8fca2a3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e7258112.gmx-interface.pages.dev |
| Branch Preview URL: | https://curtain-instant.gmx-interface.pages.dev |
src/components/Footer/Footer.tsx
Outdated
| const isHome = isHomeSite(); | ||
| const [isUserFeedbackModalVisible, setIsUserFeedbackModalVisible] = useState(false); | ||
|
|
||
| return ( | ||
| <> | ||
| <div className={cx("Footer-wrapper", { home: isHome })}> | ||
| <div className={cx("Footer-wrapper", { home: isHome, "mobile-trade-page": isMobileTradePage })}> |
There was a problem hiding this comment.
looks like this classname could be a simple pb-[52px]
|
|
||
| const headerClick = useCallback(() => { | ||
| setIsOpen(true); | ||
| }, []); |
There was a problem hiding this comment.
Suggested change
| }, []); | |
| }, [setIsOpen]); |
|
|
||
| const handleClick = useCallback(() => { | ||
| setIsOpen((prev) => !prev); | ||
| }, []); |
There was a problem hiding this comment.
Suggested change
| }, []); | |
| }, [setIsOpen]); |
hubert-de-lalye
previously approved these changes
Dec 19, 2024
midas-myth
force-pushed
the
curtain-instant
branch
from
2c50cde to
a4f7556
Compare
Release 53
colors clean up
midas-myth
force-pushed
the
curtain-instant
branch
from
a4f7556 to
0b6fb4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.