Fix: Ensure constant format strings in fmt and printf calls #196

mikelolasagasti · 2025-01-20T15:45:58Z

Go 1.24 introduces stricter checks for format string validation. This commit fixes instances where non-constant format strings were used in calls to functions like fmt.Errorf, fmt.Printf, and similar.

$ go version
go version go1.24rc2 linux/amd64

$ go vet -printf ./...
# github.com/gmeghnag/omc/cmd/upgrade
cmd/upgrade/helpers.go:46:21: non-constant format string in call to fmt.Errorf
# github.com/gmeghnag/omc/cmd/certs
# [github.com/gmeghnag/omc/cmd/certs]
cmd/certs/inspect.go:177:18: non-constant format string in call to fmt.Fprintf
# github.com/gmeghnag/omc/cmd/describe/core
cmd/describe/core/node.go:50:15: non-constant format string in call to fmt.Printf
cmd/describe/core/pod.go:47:15: non-constant format string in call to fmt.Printf

Go 1.24 introduces stricter checks for format string validation. This commit fixes instances where non-constant format strings were used in calls to functions like `fmt.Errorf`, `fmt.Printf`, and similar. Signed-off-by: Mikel Olasagasti Uranga <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Ensure constant format strings in fmt and printf calls #196

Fix: Ensure constant format strings in fmt and printf calls #196

mikelolasagasti commented Jan 20, 2025

Fix: Ensure constant format strings in fmt and printf calls #196

Are you sure you want to change the base?

Fix: Ensure constant format strings in fmt and printf calls #196

Conversation

mikelolasagasti commented Jan 20, 2025