checksum.c: Use the EVP API to compute the MD5 checksum #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLANG-FORMAT FAILURE: index 74a3a0cb7..2c8ffa691 100644
--- a/libglusterfs/src/checksum.c
+++ b/libglusterfs/src/checksum.c
@@ -41,7 +41,7 @@ void
gf_rsync_md5_checksum(unsigned char *data, size_t len, unsigned char *md5)
{
EVP_MD_CTX *mdctx;
- const EVP_MD *md = EVP_md5(); // Use the MD5 digest algorithm
+ const EVP_MD *md = EVP_md5(); // Use the MD5 digest algorithm
mdctx = EVP_MD_CTX_new();
EVP_DigestInit_ex(mdctx, md, NULL); |
Shwetha-Acharya
force-pushed
the
md5-issue
branch
3 times, most recently
from
0cb0ab9
to
5e88e7c
Compare
As MD5 function has been marked as deprecated in OpenSSL 3.0, this change uses EVP (Envelope) API to compute the MD5 checksum. Reference: https://www.openssl.org/docs/man1.0.2/man3/EVP_md5.html Also resolved make error of 'client_uid' never being NULL. Fixes: gluster#4243 and gluster#4245 Signed-off-by: root <[email protected]>
Shwetha-Acharya
force-pushed
the
md5-issue
branch
from
5e88e7c
to
4f075e4
Compare
|
/recheck smoke |
1 similar comment
|
/recheck smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As MD5 function has been marked as deprecated in OpenSSL 3.0, this change uses EVP (Envelope) API to compute the MD5 checksum.
Reference:
https://www.openssl.org/docs/man1.0.2/man3/EVP_md5.html
Fixes: #4243