Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ollama model selection work #166

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

c01o
Copy link
Contributor

@c01o c01o commented Dec 13, 2024

Thank you for developing such an excellent plugin!

I found ollama model name selection does not work.
241213obsidian-smart-composer-modelname-set-failure

The current implementation appears to have two issues:

  • Selected models are not saved into data.json.
    • fixed in l712-715
  • Selected model names are reset to the default ones when opening or refreshing the settings tab.
    • This happens because dropdown.getValue() returns nothing if there is no corresponding option.

I should mention that I’m not very familiar with this project or, more generally, with Obsidian plugin development. If there are any conventions or best practices that I’ve overlooked, please know it’s unintentional, and I’d appreciate it if you could point them out.

@glowingjade glowingjade requested a review from kevin-on December 14, 2024 15:49
@glowingjade
Copy link
Owner

Sorry for the bug. Thanks for your contribution!

@glowingjade glowingjade merged commit 81f3eb2 into glowingjade:main Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants