fix: make ollama model selection work #166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for developing such an excellent plugin!
I found ollama model name selection does not work.
The current implementation appears to have two issues:
data.json
.dropdown.getValue()
returns nothing if there is no corresponding option.I should mention that I’m not very familiar with this project or, more generally, with Obsidian plugin development. If there are any conventions or best practices that I’ve overlooked, please know it’s unintentional, and I’d appreciate it if you could point them out.