-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply numpy 2 migrations for _ types in tests #61
Conversation
Error message for failing test on macos, 3.8, oldest
|
@cbkerr For the “oldest” tests, feel free to update the NumPy pinning to the oldest version for which wheels exist for all supported platforms / Python versions. We don’t want to have to compile NumPy from a source dist to run tests. Also it is okay to drop Python 3.8, if 3.8 presents any challenges here. It has been dropped by NEP 29 / SPEC 0 and will only get security updates through October 2024. |
Co-authored-by: Bradley Dice <[email protected]>
I update the oldest numpy to 1.21.0, which is the first one that has an arm build that supports macos 11+. |
Description
Makes tests pass for numpy 2.0. Tests still pass with 1.26 too.
Applies these changes to update
float_
andcomplex_
typeshttps://numpy.org/doc/stable//numpy_2_0_migration_guide.html#changes-to-namespaces
Motivation and Context
Prepare for numpy 2.0
Checklist: