Refactor/update operation syntax #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-butler
requested review from
tcmoore3 and
shihkual
and removed request for
a team
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bdice
reviewed
Oct 31, 2022
|
CI is failing -- @b-butler let me know when this is ready to review (or if help is needed). |
|
@bdice This is failing because the flow PR has yet to be approved or merged. |
Whoops. Somehow I thought it had been merged already. I approved glotzerlab/signac-flow#681. |
Use a more appropriate verb. Co-authored-by: Bradley Dice <[email protected]>
b-butler
force-pushed
the
refactor/update-operation-syntax
branch
from
aadbab9 to
4c19bf7
Compare
tcmoore3
reviewed
Sep 5, 2023
|
@b-butler Is this PR still needed? The CI has been updated so we should be able to fix it up and merge, or close if not. |
b-butler
force-pushed
the
refactor/update-operation-syntax
branch
from
e6cee18 to
cb0cf3f
Compare
bdice
approved these changes
Nov 14, 2023
|
@b-butler I wasn't sure if this is ready to review/merge but the current changes look fine to me. Please merge if you're ready. |
b-butler
force-pushed
the
refactor/update-operation-syntax
branch
from
7feb2b5 to
689fb6f
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the examples to the current flow API.