Remove inaccurate validation tests. #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaander
added
the
validate
Now implemented in hoomd-validation.
3 tasks
|
https://github.com/glotzerlab/hoomd-validation is now public and provides a superset of all tests removed in this pull request (some tests are still in open pull requests at the time this message is posted). |
joaander
requested review from
a team,
tommy-waltmann and
Charlottez112
and removed request for
a team
Comment on lines
+22
to
+23
| **Long running tests** check for correct behavior, but require up to a minute to execute. Mark long | ||
| running tests with the ``validate`` label. |
There was a problem hiding this comment.
I think it makes sense to keep a label for the longer running tests, but what if we changed the label to be --long-tests or something along those lines intead of --validate?
There was a problem hiding this comment.
This is a breaking change. We could do this in separate pull request for v4. The canonical name would be slow.
tommy-waltmann
approved these changes
Nov 17, 2022
Charlottez112
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove inaccurate validation tests.
Motivation and context
These tests provide a false sense of correctness. They are not run long enough to sample the chosen state points. We have implemented a new validation test suite,
hoomd-validationthat implements these tests (and more) in asignac-flowproject that runs on HPC resources.Resolves #210
How has this been tested?
The CI checks pass.
Change log
Internal change, no change log entry is needed.
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.