Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deque for signal aggregation #22

Merged
merged 9 commits into from
Jul 19, 2024
Merged

Add deque for signal aggregation #22

merged 9 commits into from
Jul 19, 2024

Conversation

DomFijan
Copy link
Contributor

@DomFijan DomFijan commented Jul 18, 2024

Description

Enables signals of constant size that implement a deque which leaves out oldest signal parts while adding new ones.

Motivation

This helps online detection.

Have you (if appropriate)

  • Updated changelog
  • Updated Documentation
  • Add tests
  • Added name to contributors

@DomFijan DomFijan requested a review from janbridley July 18, 2024 18:21
@DomFijan DomFijan marked this pull request as ready for review July 18, 2024 21:37
@DomFijan DomFijan requested a review from a team July 18, 2024 21:37
dupin/data/aggregate.py Outdated Show resolved Hide resolved
Copy link
Contributor

@janbridley janbridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I left a few comments but you can merge whenever

@DomFijan DomFijan merged commit 16b8953 into main Jul 19, 2024
8 checks passed
@DomFijan DomFijan deleted the feat/make_signal_deque branch July 19, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants