Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy 2 support #15

Merged
merged 18 commits into from
Jul 3, 2024
Merged

Add numpy 2 support #15

merged 18 commits into from
Jul 3, 2024

Conversation

DomFijan
Copy link
Contributor

@DomFijan DomFijan commented Jun 23, 2024

Numpy 2.0 has been released and we should test for compatibility. Also changed the testing methodology slightly.

Description

Ensures compatibility with numpy 2.0

Do Changes Introduce Breaking Changes

Have you (if appropriate)

  • Updated changelog
  • Updated Documentation
  • Add tests
  • Added name to contributors

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.72%. Comparing base (98e866a) to head (259d212).

Current head 259d212 differs from pull request most recent head 369c418

Please upload reports for the commit 369c418 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   76.08%   75.72%   -0.37%     
==========================================
  Files          18       18              
  Lines        1104     1104              
  Branches      234      205      -29     
==========================================
- Hits          840      836       -4     
- Misses        221      225       +4     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DomFijan DomFijan requested a review from janbridley June 23, 2024 23:30
@DomFijan DomFijan marked this pull request as ready for review June 23, 2024 23:30
@DomFijan DomFijan requested a review from a team June 23, 2024 23:30
Copy link
Contributor

@janbridley janbridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@janbridley
Copy link
Contributor

Seems merging is blocked because I'm not a Dupin maintainer - I am fine forcing it through, but we may want to change the branch protection rules

@DomFijan DomFijan requested a review from joaander July 2, 2024 17:49
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joaander joaander merged commit 67f17cd into main Jul 3, 2024
7 checks passed
@joaander joaander deleted the numpy2 branch July 3, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants