Fix/tests #10
Merged
Fix/tests #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a lingering generator argumentfrom the constructor and errant documentation stating that the constructor expects a generator argument.
Make maps and reducers which require a sequence input such as percentiles in dupin.data.reduce.Percentiles require a sequence of length at least one or raise a ValueError.
This is probably the expected behavior, and in the unusual case where empty frames exist intermittently provides consistent behavior.
Set index log values to np.nan when the index doesn't exist if either the signal is too short or there are to many NANs. Also raises warnings in these cases to inform the user.
Make it work in more cases. Also updates documentation.
We don't pin the requirements in requirements.txt but do pin the requirements in ci-oldest-requirements.txt. We also add the correct requirements for it.
Makes test despite using numpy.random functions directly (implicitly through ruptures) deterministic.
Also fixes various syntax error along with various formatting things.
This was introduced only in Python 3.10.
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Need to allow for multiple spherical harmonic numbers in Steinhardt.
Keep updating until CI tests pass.
Need to check for ValueError and TypeError in pytest.raises.
Tests (due to the specific signal generated) fail on Python 3.9, but not on other Pythons.
Ensure test can finish on Python 3.9 before deadline.
We expect our tests to hit these cases through hypothesis testing.
Mostly use dict[type] over typing.Dict[type].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See git log.
Motivation
To get working CI tests.
Do Changes Introduce Breaking Changes
Have you (if appropriate)