Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or handle warnings raised by test functions #241

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

janbridley
Copy link
Collaborator

@janbridley janbridley commented Sep 14, 2024

Description

Several deprecation warnings are raised by previous tests calling old methods, so the tests have been updated to call the new variants. A minimum setter value was defined for polyhedra to avoid setting volumes and areas to subnormal values. This parameter was left at 2e-16, which is more than small enough for basically all use cases. polygon_test now uses rowan to generate random quaternions, eliminating errors that arose from the previous generation method.

Types of Changes

  • Documentation update
  • Test update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

@janbridley janbridley marked this pull request as ready for review September 14, 2024 19:49
@janbridley janbridley requested a review from DomFijan September 14, 2024 19:49
@janbridley janbridley changed the title Remove warnings raised by test functions Remove or handle warnings raised by test functions Sep 14, 2024
@janbridley janbridley merged commit 08b6242 into master Sep 16, 2024
9 checks passed
@janbridley janbridley deleted the fix/remove-deprecated-functions-in-tests branch September 16, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants