-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expect failures due to numerical precision in miniball. #183
Conversation
edit: it was just hypothesis deadlines, not flaky failures. I extended their deadlines. |
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 54.45% 54.45%
=======================================
Files 27 27
Lines 2628 2628
=======================================
Hits 1431 1431
Misses 1197 1197 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thank you for this patch!
Description
Until #179 is fixed, I added an
xfail
to the affected tests of bounding spheres for polyhedra. This ensures that library development is not stalled indefinitely due to a complex problem. See #179, #178 for details.Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist: