Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect failures due to numerical precision in miniball. #183

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

bdice
Copy link
Member

@bdice bdice commented Apr 23, 2023

Description

Until #179 is fixed, I added an xfail to the affected tests of bounding spheres for polyhedra. This ensures that library development is not stalled indefinitely due to a complex problem. See #179, #178 for details.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

@bdice
Copy link
Member Author

bdice commented Apr 23, 2023

There are additional flaky test failures here. I am not able to invest the time to diagnose these but I will xfail those too.

edit: it was just hypothesis deadlines, not flaky failures. I extended their deadlines.

@bdice bdice marked this pull request as ready for review April 23, 2023 22:48
@bdice bdice requested a review from a team April 23, 2023 22:48
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #183 (0177e7f) into master (429f494) will not change coverage.
The diff coverage is n/a.

❗ Current head 0177e7f differs from pull request most recent head f4a1cf8. Consider uploading reports for the commit f4a1cf8 to get more accurate results

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   54.45%   54.45%           
=======================================
  Files          27       27           
  Lines        2628     2628           
=======================================
  Hits         1431     1431           
  Misses       1197     1197           

@bdice bdice enabled auto-merge (squash) April 23, 2023 23:19
Copy link
Collaborator

@janbridley janbridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you for this patch!

@bdice bdice merged commit 865f444 into master Jun 20, 2023
@bdice bdice deleted the xfail-bounding-sphere branch June 20, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants