Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial revert (maintaining the added unit tests) in the fix for #58 #90

Merged
merged 1 commit into from
Oct 11, 2016

Conversation

birme
Copy link
Contributor

@birme birme commented Oct 11, 2016

Based on the discussion in #58 and in light of that the RFC stating that URI is only required if key method is not NONE I have reverted the fix. And actually other attributes MUST NOT be present if method is NONE. That part is not enforced in this commit. It may be value to keep the added test cases already merged, and why I created a new PR with the revert. It is up to you if you want to use this or just revert the old PR.

…s not NONE. And actually other attributes MUST NOT be present if method is NONE. That part is not enforced in this commit
@coveralls
Copy link

coveralls commented Oct 11, 2016

Coverage Status

Coverage decreased (-0.01%) to 96.935% when pulling 8f9c2d5 on Eyevinn:fix-58 into a725489 on globocom:master.

@leandromoreira leandromoreira merged commit 06a9ab8 into globocom:master Oct 11, 2016
@leandromoreira
Copy link
Contributor

Thank you very much sir :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants