Use toLocaleString for more useful examples of formatting currency

glin · Oct 14, 2023 · 1815629 · 1815629
1 parent bcb0884
commit 1815629
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/vignettes/cookbook/cookbook.Rmd b/vignettes/cookbook/cookbook.Rmd
@@ -576,7 +576,7 @@ reactable(
         state.sortedData.forEach(function(row) {
           total += row[column.id]
         })
-        return '$' + total.toFixed(2)
+        return total.toLocaleString('en-US', { style: 'currency', currency: 'USD' })
       }")
     )
   ),
@@ -601,7 +601,7 @@ reactable(
         state.sortedData.forEach(function(row) {
           total += row[column.id]
         })
-        return '$' + total.toFixed(2)
+        return total.toLocaleString('en-US', { style: 'currency', currency: 'USD' })
       }")
     )
   ),

diff --git a/vignettes/examples.Rmd b/vignettes/examples.Rmd
@@ -765,7 +765,7 @@ reactable(
       aggregate = "sum",
       # Render aggregated cell as currency
       aggregated = JS("function(cellInfo) {
-        return '$' + cellInfo.value.toFixed(2)
+        return cellInfo.value.toLocaleString('en-US', { style: 'currency', currency: 'USD' })
       }")
     )
   )
@@ -918,7 +918,7 @@ reactable(
         state.sortedData.forEach(function(row) {
           total += row[column.id]
         })
-        return '$' + total.toFixed(2)
+        return total.toLocaleString('en-US', { style: 'currency', currency: 'USD' })
       }")
     )
   ),